Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix link to reference #1263

Merged
merged 4 commits into from
Feb 9, 2024
Merged

docs: fix link to reference #1263

merged 4 commits into from
Feb 9, 2024

Conversation

Borda
Copy link
Collaborator

@Borda Borda commented Dec 13, 2023

Why are these changes needed?

it does not render as a link in the docs, see: https://microsoft.github.io/FLAML/docs/reference/default/greedy

Related issue number

Checks

@Borda Borda requested a review from sonichi December 13, 2023 11:56
@Borda Borda added documentation Improvements or additions to documentation bug Something isn't working labels Dec 13, 2023
@Borda
Copy link
Collaborator Author

Borda commented Dec 14, 2023

@sonichi, I do not think that my docs fix would break the code as the tests are failing now; it is coming from the master or some flaky cases?

@sonichi
Copy link
Collaborator

sonichi commented Dec 30, 2023

This looks an issue related to spark. @thinkall for awareness.

@Borda
Copy link
Collaborator Author

Borda commented Jan 19, 2024

seems that very same test are failing also on main branch so would be worse to check it to unblock all pending PRs

@thinkall thinkall mentioned this pull request Feb 4, 2024
3 tasks
@thinkall
Copy link
Collaborator

thinkall commented Feb 4, 2024

This looks an issue related to spark. @thinkall for awareness.

I've raised a PR #1274 to fix the issues.

flaml/default/greedy.py Outdated Show resolved Hide resolved
Co-authored-by: Li Jiang <bnujli@gmail.com>
Copy link
Collaborator

@thinkall thinkall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@codecov-commenter
Copy link

codecov-commenter commented Feb 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b645da3) 71.72% compared to head (0d2039c) 71.59%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1263      +/-   ##
==========================================
- Coverage   71.72%   71.59%   -0.13%     
==========================================
  Files          83       83              
  Lines       11249    11249              
  Branches     2360     2360              
==========================================
- Hits         8068     8054      -14     
- Misses       2726     2738      +12     
- Partials      455      457       +2     
Flag Coverage Δ
unittests 71.47% <ø> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Borda
Copy link
Collaborator Author

Borda commented Feb 9, 2024

@sonichi kindly reminder for review... 🐿️

@sonichi sonichi added this pull request to the merge queue Feb 9, 2024
Merged via the queue into microsoft:main with commit 249f0f1 Feb 9, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants