Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spark errors #1274

Merged
merged 6 commits into from
Feb 9, 2024
Merged

Fix spark errors #1274

merged 6 commits into from
Feb 9, 2024

Conversation

thinkall
Copy link
Collaborator

@thinkall thinkall commented Feb 4, 2024

Why are these changes needed?

Fix a few errors related to spark. It's needed to fix the test errors in other PRs such as #1263

  • spark mlflow version not found issue
  • joblib issue

Related issue number

Checks

flaml/tune/tune.py Outdated Show resolved Hide resolved
@sonichi sonichi requested a review from skzhang1 February 5, 2024 15:23
flaml/tune/tune.py Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Feb 6, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (0415638) 71.72% compared to head (dd22038) 71.64%.

Files Patch % Lines
flaml/tune/spark/utils.py 40.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1274      +/-   ##
==========================================
- Coverage   71.72%   71.64%   -0.09%     
==========================================
  Files          83       83              
  Lines       11244    11249       +5     
  Branches     2359     2360       +1     
==========================================
- Hits         8065     8059       -6     
- Misses       2724     2735      +11     
  Partials      455      455              
Flag Coverage Δ
unittests 71.51% <40.00%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thinkall thinkall added this pull request to the merge queue Feb 7, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 7, 2024
@thinkall thinkall added this pull request to the merge queue Feb 7, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 7, 2024
@thinkall thinkall added this pull request to the merge queue Feb 7, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 7, 2024
@thinkall thinkall added this pull request to the merge queue Feb 8, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 8, 2024
@thinkall thinkall added this pull request to the merge queue Feb 8, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 8, 2024
@thinkall thinkall added this pull request to the merge queue Feb 8, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 8, 2024
@thinkall thinkall added this pull request to the merge queue Feb 9, 2024
Merged via the queue into main with commit b645da3 Feb 9, 2024
13 of 16 checks passed
@thinkall thinkall deleted the fix_spark_errors branch February 9, 2024 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants