Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix alerts #644

Merged
merged 20 commits into from
Jul 26, 2022
Merged

Fix alerts #644

merged 20 commits into from
Jul 26, 2022

Conversation

skzhang1
Copy link
Collaborator

Fix the alerts

@skzhang1 skzhang1 requested a review from sonichi July 21, 2022 18:36
@liususan091219
Copy link
Collaborator

liususan091219 commented Jul 26, 2022

Fix the alerts

Hi @skzhang1 thanks for your pull request. The code has some runtime issues but we fixed them with PR #647 . Could you merge the main branch to fix those issues in your PR with the following lines? Thanks.

git fetch upstream 
git merge upstream/main your_branch_name

@skzhang1 skzhang1 merged commit ebbfa0c into microsoft:main Jul 26, 2022
@skzhang1
Copy link
Collaborator Author

@liususan091219 Sure, I have merged to the main branch. If there exists problems, please tell me. Thanks!

@liususan091219
Copy link
Collaborator

liususan091219 commented Jul 26, 2022

@skzhang1 Awesome. Thanks for your help and quick response!

@skzhang1 skzhang1 deleted the fix_alerts branch November 5, 2022 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants