This PR fixes the frequent NLP bugs in the other PRs #647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sonichi
reviewed
Jul 23, 2022
test/nlp/test_default.py
Outdated
| @@ -91,9 +91,13 @@ def test_points_to_evaluate(): | |||
| automl_settings = get_automl_settings(estimator_name="transformer_ms") | |||
|
|
|||
| automl_settings["estimator_list"] = ["transformer_ms"] | |||
| automl_settings["starting_points"] = "data" | |||
|
|
|||
| automl_settings["starting_points"] = "data:test/nlp/default/" | |||
| del automl_settings["fit_kwargs_by_estimator"]["transformer_ms"]["model_path"] | |||
There was a problem hiding this comment.
Why did we have "model_path" in fit_kwargs_by_estimator in the beginning? Shall we remove it in get_automl_settings()?
There was a problem hiding this comment.
get automl settings is for providing a low cost config so it includes overwriting the model to Electra small
There was a problem hiding this comment.
I said fit_kwargs_by_estimator. Why does it contain "model_path"?
There was a problem hiding this comment.
We must overwrite model_path to electra small. Do you mean to overwrite "model_path", why do we do it via fit_kwargs_by_estimator instead of other options (such as fit_kwargs)?
sonichi
approved these changes
Jul 25, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable py3.6 for text summarization to fix the NLP bug in the other PRs