Tree: Include lineage as part of cell IDs #16434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: dds
experimental/dds/tree2/src/feature-libraries/sequence-field/utils.ts
Outdated
Show resolved
Hide resolved
experimental/dds/tree2/src/test/feature-libraries/sequence-field/sequenceChangeRebaser.spec.ts
Outdated
Show resolved
Hide resolved
experimental/dds/tree2/src/test/feature-libraries/sequence-field/sequenceChangeRebaser.spec.ts
Outdated
Show resolved
Hide resolved
experimental/dds/tree2/src/feature-libraries/sequence-field/format.ts
Outdated
Show resolved
Hide resolved
…ils.ts Co-authored-by: yann-achard-MS <97201204+yann-achard-MS@users.noreply.github.com>
⯅ @fluid-example/bundle-size-tests: +3.54 KB
Baseline commit: 65c8073 |
yann-achard-MS
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change creates a new type,
CellId, which isChangeAtomIdwith optional lineage. Sequence field marks targeting existing cells now useCellIdinstead ofChangeAtomIdto identify empty cells, and lineage is stored there instead of directly on the mark. Lineage is still stored directly on new attach marks.