Jsonable to support interfaces #1816
Conversation
| @@ -26,4 +29,8 @@ export type JsonableArray<T> = Jsonable<T>[]; | |||
| * - Non-finite numbers (`NaN`, `+/-Infinity`) are also coerced to `null`. | |||
| * - (`null` always serializes as `null`.) | |||
| */ | |||
| export type Jsonable<T = JsonablePrimitive> = T | JsonableArray<T> | JsonableObject<T>; | |||
| export type Jsonable<T> = { | |||
| [P in keyof T]: T[P] extends JsonablePrimitiveArrayOrObject | |||
There was a problem hiding this comment.
i just pushed a PR for basically the same thing 😋 check it out #1823
There was a problem hiding this comment.
I think this might be too loose. Does it fail if an interface isn't jsonable?
There was a problem hiding this comment.
Yes, it covers all the scenarios I could think of
There was a problem hiding this comment.
Something something... great minds think alike. lol
I think I like this one because the consumption syntax is much simpler and only uses the one type:
function foo<T extends Jsonable<T>>(a: T): void {
}There was a problem hiding this comment.
i think we need type recursion to make this work
There was a problem hiding this comment.
mine fails with that too
There was a problem hiding this comment.
I approve of both. :-)
Slight preference for end-user ergonomics of the grand unified Jsonable<T>approach, if the results are comparable.
|
closing on account of Tony's PR #1823 |
Let Jsonable support interfaces