Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deps in server release group: axios to 1.6.2, compression to 4.6.2 #18312

Merged
merged 2 commits into from
Nov 15, 2023

Conversation

alexvy86
Copy link
Contributor

@alexvy86 alexvy86 commented Nov 15, 2023

Description

Updates axios to 1.6.2 across the server release group with two objectives:

  • Address CVE-2023-45857
  • Synchronize the axios dependency in tinylicious with the rest of the packages in the server release group
    • Addressing an issue we have right now where t9s changing global defaults for Axios doesn't affect code imported from the other server packages that also use Axios, because they're effectively using different modules (from different versions).

Did this by running pnpm up -r axios@1.6.2 from server/routerlicious.

Also updates compression to 4.6.2 to sync tinylicious with the rest of the release group. Note that package.json for other packages said 4.5.3 but the lockfile already used 4.6.2. That was done with pnpm up -r socket.io@4.5.3.

Reviewer Guidance

The review process is outlined on this wiki page.

AB#6252

@alexvy86 alexvy86 requested review from msfluid-bot and a team as code owners November 15, 2023 01:55
@github-actions github-actions bot added area: server Server related issues (routerlicious) base: main PRs targeted against main branch labels Nov 15, 2023
@alexvy86 alexvy86 requested review from tylerbutler and a team November 15, 2023 01:56
@alexvy86 alexvy86 merged commit 3f6b44c into microsoft:main Nov 15, 2023
26 checks passed
@alexvy86 alexvy86 deleted the sync-axios-versions branch November 15, 2023 16:02
sonalideshpandemsft pushed a commit to sonalideshpandemsft/FluidFramework that referenced this pull request Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: server Server related issues (routerlicious) base: main PRs targeted against main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants