[Port v2int/7.4] Reduce v2int7.4 bundle size #19187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts field (microsoft#18825) This PR updates sequence and merge-tree to generate proper types in ESM builds and adds an exports field. I had to update the test files a bit to clean up imports. I also added a ./dist/test export from merge-tree since its internals are used by sequence tests. This is a demonstration of the mechanism we will have to use any time we want to export something for use in another package. No more reaching into internals! This PR includes some configuration and settings changes that are not strictly needed for this PR, but splitting them out doesn't seem worth the time since they're all needed for other pending PRs like microsoft#18823 and
microsoft#18822) This PR updates client-utils to: - generate proper types in ESM builds - enable type testing - builds tests using node16 module resolution It does NOT add an exports field, because doing that right now breaks a lot of downstream compilation. We should be able to resolve that once more/all packages are using node16 module resolution.
tyler-cai-microsoft
requested review from
msfluid-bot and
a team
as code owners
tyler-cai-microsoft
changed the title
…o be used in any ci:pipeline
Abe27342
approved these changes
Jan 10, 2024
tyler-cai-microsoft
merged commit f9ef2f9
into
microsoft:release/v2int/7.4
28 of 30 checks passed
|
Note: I thought automatically squash and merge was on, and merged a little early |
tyler-cai-microsoft
added a commit
to tyler-cai-microsoft/FluidFramework
that referenced
this pull request
Jan 12, 2024
This reverts commit f9ef2f9.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ported PRs:
Description
Our partner team notified us of a 150kb increase in size when consuming
2.0.0-internal.7.4.x. After an investigation into our bundle size telemetry, it was determined that these two commits in main had reduced the bundle size by about ~100kb.Impact
Reduce bundle size by ~100kb.