Reset joinSession cache only on connect_document_error

[pragya91]

The response of joinSession api is saved in the cache (for the duration it is valid) so that, in case there is a socket disconnect, we can use the same socket endpoint from the cache instead of making a new joinSession network request.
Up until now, the odsp-driver code was clearing the cache on any error that occurred on the socket, which is incorrect.

This PR changes the code such that it only clears the cache if the error is a fluid protocol error (connect_document_error), and does not clear the cache if the error is socket.io error (connect_error).

AB#7057

[msfluid-bot]

⯅ @fluid-example/bundle-size-tests: +54 Bytes

Metric Name	Baseline Size	Compare Size	Size Diff
aqueduct.js	514.59 KB	514.59 KB	■ No change
connectionState.js	680 Bytes	680 Bytes	■ No change
containerRuntime.js	249.02 KB	249.02 KB	■ No change
loader.js	128.15 KB	128.15 KB	■ No change
map.js	41.36 KB	41.36 KB	■ No change
matrix.js	143.67 KB	143.67 KB	■ No change
odspDriver.js	97.5 KB	97.5 KB	■ No change
odspPrefetchSnapshot.js	41.87 KB	41.87 KB	■ No change
sharedString.js	161.26 KB	161.26 KB	■ No change
sharedTree.js	330.11 KB	330.11 KB	■ No change
Total Size	1.81 MB	1.81 MB	⯅ +54 Bytes

---

Baseline commit: 1d07902

Generated by 🚫 dangerJS against b6baf1a

[agarwal-navin]

From the comment where this is called from, it looks like this is not a socket error. So, maybe it should not be called socket error:

Consider adding the handler directly as errorDetails or something a property and the call site can decide based on that to clear cache or not.

[agarwal-navin]

Also, consider adding this new property to IAnyDriverError (or any of its base interfaces) to make it type safe. That way, the call site doesn't have to cast to any.

[pragya91]

I like the idea of adding the handler value into the error props itself. i.e. instead of having isSocketError flag, just adding a property like {errorFrom: handler} into the error props. That way all the possible values will be visible to the odspDelayLoadedDeltaStream to consume if needed in the future.

I am not too confident about adding the property into the IAnyDriverError interface (primarily because it is a more committing change :D). @vladsud If you have any insights to share about this, would really appreciate it!

[pragya91]

@agarwal-navin Wanted to confirm with you if you wanted to do one last review on this PR before I merge. I have made the changes to add the complete handler property value to the error object, but not adding the prop to the IAnyDriverError because I don't see it adding value anytime soon for other drivers.