Revert: Reset joinSession cache only on connect_document_error

[pragya91]

Reverts #19974 PR which was applied as a performance improvement. In the original PR, we checked for the kind of error received on the socket to decide whether to clear joinSession cache or not and reuse the existing session whenever possible. However a bug was identified where one section of the code was not update to stamp the errorFrom property which is used to perform such check which resulted in the cache never clearing for and the code getting stuck in a loop to continue connection retries.

Impact of revert: There is no compatibility-issue/regression that this revert would introduce, as it was only a perf improvement.

Follow up: Captured in AB#7833

[msfluid-bot]

⯆ @fluid-example/bundle-size-tests: -66 Bytes

Metric Name	Baseline Size	Compare Size	Size Diff
aqueduct.js	452.8 KB	452.8 KB	■ No change
azureClient.js	549.21 KB	549.2 KB	⯆ -12 Bytes
connectionState.js	680 Bytes	680 Bytes	■ No change
containerRuntime.js	256.01 KB	256.01 KB	■ No change
fluidFramework.js	338.57 KB	338.57 KB	■ No change
loader.js	133.01 KB	133.01 KB	■ No change
map.js	41.42 KB	41.42 KB	■ No change
matrix.js	143.43 KB	143.43 KB	■ No change
odspClient.js	517.56 KB	517.56 KB	■ No change
odspDriver.js	97.52 KB	97.52 KB	■ No change
odspPrefetchSnapshot.js	42.39 KB	42.39 KB	■ No change
sharedString.js	161.24 KB	161.24 KB	■ No change
sharedTree.js	338.57 KB	338.57 KB	■ No change
Total Size	3.15 MB	3.15 MB	⯆ -66 Bytes

---

Baseline commit: 8d501fc

Generated by 🚫 dangerJS against 7955d19