Fix "savedOp" metadata property propagation for grouped ops #20837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: runtime
kian-thompson
approved these changes
Apr 25, 2024
anthony-murphy
pushed a commit
to anthony-murphy/FluidFramework-1
that referenced
this pull request
Apr 29, 2024
…t#20837) Container class will set savedOp property on op before processing stashed ops. Container Runtime uses this information to differentiate ops. I do not see us propagating savedOp metadata property from grouped ops (as visible in Container) to ungrouped ops. OpGroupingManager.ungroupOp() does not do it as far as I can see. I think we are getting lucky with ID compression ops as they are usually not grouped (there is usually a single ID compression op, as it's part of its own batch). When/if any of those assumptions change, this code would stop working. Propagate properly this property.
anthony-murphy
pushed a commit
to anthony-murphy/FluidFramework-1
that referenced
this pull request
Apr 29, 2024
…t#20837) Container class will set savedOp property on op before processing stashed ops. Container Runtime uses this information to differentiate ops. I do not see us propagating savedOp metadata property from grouped ops (as visible in Container) to ungrouped ops. OpGroupingManager.ungroupOp() does not do it as far as I can see. I think we are getting lucky with ID compression ops as they are usually not grouped (there is usually a single ID compression op, as it's part of its own batch). When/if any of those assumptions change, this code would stop working. Propagate properly this property.
anthony-murphy
added a commit
that referenced
this pull request
Apr 29, 2024
#20837) (#20899) Port of: #20837 Container class will set savedOp property on op before processing stashed ops. Container Runtime uses this information to differentiate ops. I do not see us propagating savedOp metadata property from grouped ops (as visible in Container) to ungrouped ops. OpGroupingManager.ungroupOp() does not do it as far as I can see. I think we are getting lucky with ID compression ops as they are usually not grouped (there is usually a single ID compression op, as it's part of its own batch). When/if any of those assumptions change, this code would stop working. Propagate properly this property. Co-authored-by: Vlad Sudzilouski <vladsud@microsoft.com>
anthony-murphy
added a commit
that referenced
this pull request
Apr 29, 2024
#20837) (#20902) Port of: #20837 Container class will set savedOp property on op before processing stashed ops. Container Runtime uses this information to differentiate ops. I do not see us propagating savedOp metadata property from grouped ops (as visible in Container) to ungrouped ops. OpGroupingManager.ungroupOp() does not do it as far as I can see. I think we are getting lucky with ID compression ops as they are usually not grouped (there is usually a single ID compression op, as it's part of its own batch). When/if any of those assumptions change, this code would stop working. Propagate properly this property. Co-authored-by: Vlad Sudzilouski <vladsud@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Container class will set savedOp property on op before processing stashed ops.
Container Runtime uses this information to differentiate ops.
I do not see us propagating savedOp metadata property from grouped ops (as visible in Container) to ungrouped ops. OpGroupingManager.ungroupOp() does not do it as far as I can see. I think we are getting lucky with ID compression ops as they are usually not grouped (there is usually a single ID compression op, as it's part of its own batch). When/if any of those assumptions change, this code would stop working.
Propagate properly this property.