Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rc.3 Port: Fix "savedOp" metadata property propagation for grouped ops (#20837) #20899

Conversation

anthony-murphy
Copy link
Contributor

Port of: #20837

Container class will set savedOp property on op before processing stashed ops. Container Runtime uses this information to differentiate ops.

I do not see us propagating savedOp metadata property from grouped ops (as visible in Container) to ungrouped ops. OpGroupingManager.ungroupOp() does not do it as far as I can see. I think we are getting lucky with ID compression ops as they are usually not grouped (there is usually a single ID compression op, as it's part of its own batch). When/if any of those assumptions change, this code would stop working.

Propagate properly this property.

…t#20837)

Container class will set savedOp property on op before processing stashed ops.
Container Runtime uses this information to differentiate ops.

I do not see us propagating savedOp metadata property from grouped ops (as visible in Container) to ungrouped ops. OpGroupingManager.ungroupOp() does not do it as far as I can see. I think we are getting lucky with ID compression ops as they are usually not grouped (there is usually a single ID compression op, as it's part of its own batch). When/if any of those assumptions change, this code would stop working.

Propagate properly this property.
@msfluid-bot
Copy link
Collaborator

@fluid-example/bundle-size-tests: +260 Bytes
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 453.35 KB 453.42 KB +65 Bytes
azureClient.js 546.42 KB 546.48 KB +65 Bytes
connectionState.js 680 Bytes 680 Bytes No change
containerRuntime.js 256.25 KB 256.32 KB +65 Bytes
fluidFramework.js 339.39 KB 339.39 KB No change
loader.js 129.89 KB 129.89 KB No change
map.js 41.35 KB 41.35 KB No change
matrix.js 143.62 KB 143.62 KB No change
odspClient.js 514.89 KB 514.96 KB +65 Bytes
odspDriver.js 97.52 KB 97.52 KB No change
odspPrefetchSnapshot.js 42.39 KB 42.39 KB No change
sharedString.js 161.39 KB 161.39 KB No change
sharedTree.js 339.39 KB 339.39 KB No change
Total Size 3.14 MB 3.14 MB +260 Bytes

Baseline commit: 30397c0

Generated by 🚫 dangerJS against c7f07b5

@anthony-murphy anthony-murphy merged commit ea91721 into microsoft:release/client/2.0.0-rc.3.0 Apr 29, 2024
27 checks passed
@anthony-murphy anthony-murphy deleted the port-20837 branch April 29, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants