Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rc.2 Port: Fix "savedOp" metadata property propagation for grouped ops (#20837) #20902

Commits on Apr 29, 2024

  1. Fix "savedOp" metadata property propagation for grouped ops (microsof…

    …t#20837)
    
    Container class will set savedOp property on op before processing stashed ops.
    Container Runtime uses this information to differentiate ops.
    
    I do not see us propagating savedOp metadata property from grouped ops (as visible in Container) to ungrouped ops. OpGroupingManager.ungroupOp() does not do it as far as I can see. I think we are getting lucky with ID compression ops as they are usually not grouped (there is usually a single ID compression op, as it's part of its own batch). When/if any of those assumptions change, this code would stop working.
    
    Propagate properly this property.
    vladsud authored and anthony-murphy committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    400f91f View commit details
    Browse the repository at this point in the history