Explicitly export members of fluidRouter to workaround Typescript issue #5056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
curtisman
reviewed
Feb 5, 2021
| // So we export the explicit members as a workaround: | ||
| // https://github.com/microsoft/TypeScript/issues/18877#issuecomment-476921038 | ||
| export { | ||
| IRequest, |
There was a problem hiding this comment.
I wonder whether we can just export by name the one sthat we would augment by name and the rest can still be export *?
There was a problem hiding this comment.
We can with some eslint-disables, either way seems fine to me:
export {
// eslint-disable-next-line import/export
IRequestHeader,
} from "./fluidRouter";
// eslint-disable-next-line import/export
export * from "./fluidRouter";There was a problem hiding this comment.
I probably prefer the current approach personally, but happy to change if you'd like.
|
/azp run Build - client packages |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ChumpChief
added a commit
to ChumpChief/FluidFramework
that referenced
this pull request
Feb 5, 2021
…ue (microsoft#5056) When downstream customers augment the IRequestHeader, the [index: string]: any; signature is lost and they end up with "property does not exist" errors. This change uses this workaround to resolve the issue: microsoft/TypeScript#18877 (comment)
ChumpChief
added a commit
that referenced
this pull request
Feb 6, 2021
…ue (#5056) (#5063) When downstream customers augment the IRequestHeader, the [index: string]: any; signature is lost and they end up with "property does not exist" errors. This change uses this workaround to resolve the issue: microsoft/TypeScript#18877 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When downstream customers augment the
IRequestHeader, the[index: string]: any;signature is lost and they end up with "property does not exist" errors.This change uses this workaround to resolve the issue:
microsoft/TypeScript#18877 (comment)