Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.34 port] Explicitly export members of fluidRouter to workaround Typescript issue #5063

Merged
merged 1 commit into from
Feb 6, 2021

Conversation

ChumpChief
Copy link
Contributor

When downstream customers augment the IRequestHeader, the [index: string]: any; signature is lost and they end up with "property does not exist" errors.

This change uses this workaround to resolve the issue:
microsoft/TypeScript#18877 (comment)

…ue (microsoft#5056)

When downstream customers augment the IRequestHeader, the [index: string]: any; signature is lost and they end up with "property does not exist" errors.

This change uses this workaround to resolve the issue:
microsoft/TypeScript#18877 (comment)
@msfluid-bot
Copy link
Collaborator

Could not find a usable baseline build with search starting at CI 22bed61

Generated by 🚫 dangerJS against 4e421f8

Copy link
Member

@curtisman curtisman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@ChumpChief ChumpChief merged commit 66d6183 into microsoft:release/0.34 Feb 6, 2021
@ChumpChief ChumpChief deleted the ExplicitExport34 branch February 6, 2021 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants