-
Notifications
You must be signed in to change notification settings - Fork 733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GSL_SUPPRESS(y)
expands to [[gsl::suppress("x")]]
for clang
#1130
Comments
@edgchen1 good catch. If you'd like to tackle this one you can assign the issue to yourself. note: whoever ends up implementing this will want to add a test-case for the suppression behavior. |
Any suggestions on how to add a test for it? I'm not too familiar with the existing test setup, but from a quick look it wasn't obvious to me. |
Good question. I was thinking about compiling with I am not a cmake expert and right now I don't want to invest more time to try to implement the tests. From a look into the test code here I found that there are some I hope that dmitrykobets-msft will accept a fix even without an extra test and that he comes up with an idea how to get the test case working. When the test case is implemented, also the |
Fair enough; looks like we will want some form of compilation-failure testing, and currently |
Thanks for the input @beinhaerter and @dmitrykobets-msft. I created a small PR (#1133) with just the change in this issue. |
Here's the definition of
GSL_SUPPRESS
:GSL/include/gsl/assert
Lines 48 to 50 in 4300304
This always expands to
[[gsl::suppress("x")]]
because the"x"
string literal won't be replaced.We probably want something like this instead:
The text was updated successfully, but these errors were encountered: