Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Clang GSL_SUPPRESS to stringize parameter instead of using fixed string literal. #1133

Merged
merged 3 commits into from
Sep 11, 2023
Merged

Update Clang GSL_SUPPRESS to stringize parameter instead of using fixed string literal. #1133

merged 3 commits into from
Sep 11, 2023

Conversation

edgchen1
Copy link
Contributor

@edgchen1 edgchen1 commented Sep 2, 2023

Fix #1130.

@edgchen1 edgchen1 mentioned this pull request Sep 2, 2023
Closed
@dmitrykobets-msft
Copy link
Member

dmitrykobets-msft commented Sep 5, 2023 •
edited

@edgchen1 it looks like gsl/byte also had a definition of GSL_SUPPRESS. After digging into it, the redefinition doesn't look necessary. I've created a pull request edgchen1#1 into your fork with the necessary changes to hopefully fix the failing tests.

@edgchen1
Copy link
Contributor Author

edgchen1 commented Sep 6, 2023

@edgchen1 it looks like gsl/byte also had a definition of GSL_SUPPRESS. After digging into it, the redefinition doesn't look necessary. I've created a pull request edgchen1#1 into your fork with the necessary changes to hopefully fix the failing tests.

Thanks! Merged your fix.

@dmitrykobets-msft
Copy link
Member

Hi @edgchen1 sorry in the delay in getting this merged; our CI was having some issues that are now resolved.
Thanks for the fix, merging.

@dmitrykobets-msft dmitrykobets-msft merged commit 52212c2 into microsoft:main Sep 11, 2023
66 checks passed
@edgchen1 edgchen1 deleted the edgchen1/fix_gsl_suppress branch September 12, 2023 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GSL_SUPPRESS(y) expands to [[gsl::suppress("x")]] for clang
2 participants
@edgchen1 @dmitrykobets-msft