Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Namespace "Guide" is ambiguous. Prefer "GSL" #9

Closed
AndrewPardoe opened this issue Sep 18, 2015 · 3 comments
Closed

Namespace "Guide" is ambiguous. Prefer "GSL" #9

AndrewPardoe opened this issue Sep 18, 2015 · 3 comments
Assignees
@neilmacintosh
Labels
resolved

Comments

@AndrewPardoe
Copy link
Contributor

The name of your codebase is GSL. Why do you have a separate abbreviation for the namespace? I'd prefer that your types be under "gsl::"
@gdr-at-ms
Copy link
Member

Agreed. Except probably 'gsl' -- lower caps :-)

@neilmacintosh
Copy link
Collaborator

All seems perfectly sensible to me. I'll prepare a PR in the next day or so.

@ivan-aksamentov ivan-aksamentov mentioned this issue Sep 25, 2015
Closed
@neilmacintosh neilmacintosh mentioned this issue Sep 29, 2015
Merged
@neilmacintosh
Copy link
Collaborator

Fixed by #104.

clrxbl added a commit to clrxbl/GSL that referenced this issue Oct 8, 2018
@clrxbl
Add Clang 3.12.3 to README.md
5578786 
Test project /GSL
      Start  1: span_tests
 1/15 Test  microsoft#1: span_tests .......................   Passed    0.01 sec
      Start  2: multi_span_tests
 2/15 Test  microsoft#2: multi_span_tests .................   Passed    0.02 sec
      Start  3: strided_span_tests
 3/15 Test  microsoft#3: strided_span_tests ...............   Passed    0.01 sec
      Start  4: string_span_tests
 4/15 Test  microsoft#4: string_span_tests ................   Passed    0.01 sec
      Start  5: at_tests
 5/15 Test  microsoft#5: at_tests .........................   Passed    0.00 sec
      Start  6: bounds_tests
 6/15 Test  microsoft#6: bounds_tests .....................   Passed    0.01 sec
      Start  7: notnull_tests
 7/15 Test  microsoft#7: notnull_tests ....................   Passed    0.01 sec
      Start  8: assertion_tests
 8/15 Test  microsoft#8: assertion_tests ..................   Passed    0.01 sec
      Start  9: utils_tests
 9/15 Test  microsoft#9: utils_tests ......................   Passed    0.01 sec
      Start 10: owner_tests
10/15 Test microsoft#10: owner_tests ......................   Passed    0.00 sec
      Start 11: byte_tests
11/15 Test microsoft#11: byte_tests .......................   Passed    0.01 sec
      Start 12: algorithm_tests
12/15 Test microsoft#12: algorithm_tests ..................   Passed    0.00 sec
      Start 13: sloppy_notnull_tests
13/15 Test microsoft#13: sloppy_notnull_tests .............   Passed    0.00 sec
      Start 14: no_exception_throw_tests
14/15 Test microsoft#14: no_exception_throw_tests .........   Passed    0.00 sec
      Start 15: no_exception_ensure_tests
15/15 Test microsoft#15: no_exception_ensure_tests ........   Passed    0.00 sec

100% tests passed, 0 tests failed out of 15

Total Test time (real) =   0.11 sec

Arch Linux w/ Clang 3.12.3
@clrxbl clrxbl mentioned this issue Oct 8, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@neilmacintosh neilmacintosh

Labels
resolved
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@AndrewPardoe @neilmacintosh @gdr-at-ms