Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up final_act and finally, closes #752 and #846 #977

Merged
merged 11 commits into from
Oct 10, 2022
Merged

Clean up final_act and finally, closes #752 and #846 #977

merged 11 commits into from
Oct 10, 2022

Commits on Feb 24, 2021

  1. Clean up final_act and finally, closes #752 and #846

    @hsutter
    hsutter committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    4cd8873 View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2021

  1. Restored copyability to final_action

    @hsutter
    hsutter committed Feb 25, 2021
    Configuration menu
    Copy the full SHA
    39e956b View commit details
    Browse the repository at this point in the history

  2. Defaulted copying

    @hsutter
    hsutter committed Feb 25, 2021
    Configuration menu
    Copy the full SHA
    e9c5753 View commit details
    Browse the repository at this point in the history

  3. Figured out test failures, removed move test 

    We shouldn't be moving these `final_action`s around, that wasn't part of the C++CG design requirements.
Went back to the simple version of `final_action`.
    @hsutter
    hsutter committed Feb 25, 2021
    Configuration menu
    Copy the full SHA
    f59cb79 View commit details
    Browse the repository at this point in the history

  4. Fine, make it move-constructible (only) 

    To satisfy some compilers.
And might as well reinstate that test case.
    @hsutter
    hsutter committed Feb 25, 2021
    Configuration menu
    Copy the full SHA
    020ddc4 View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2022

  1. Applying Casey's suggestions 

    Applying @CaseyCarter's suggested forwarding changes
And adding `[[nodiscard]]` on `finally`

Thanks Casey -- somehow this slipped through the cracks for a year.
    @hsutter
    hsutter committed Aug 30, 2022
    Configuration menu
    Copy the full SHA
    6b284bf View commit details
    Browse the repository at this point in the history

  2. Made noexcept-consistent

    @hsutter
    hsutter committed Aug 30, 2022
    Configuration menu
    Copy the full SHA
    3865bac View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2022

  1. Applying Casey's an Dmitry's changes...

    @hsutter
    hsutter committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    352f73d View commit details
    Browse the repository at this point in the history

  2. Add remove_cv too per Casey's suggestion 

    Co-authored-by: Casey Carter <Casey@Carter.net>
    @hsutter @CaseyCarter
    hsutter and CaseyCarter committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    d569ed6 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2022

  1. Merge remote-tracking branch 'origin/main' into final_action-revision

    @dmitrykobets-msft
    dmitrykobets-msft committed Sep 26, 2022
    Configuration menu
    Copy the full SHA
    8840d87 View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2022

  1. Properly handle finally(actual_function) (#1056) 

    `finally` needs to use `decay_t` instead of `remove_cvref_t` so it can properly accept non-object function arguments by decaying to function pointer type. Adds test coverage for this use case which was previously missing.
    @CaseyCarter
    CaseyCarter committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    d9ffa11 View commit details
    Browse the repository at this point in the history