Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: update nginx configuration to adapt to upload large files #589

Merged
merged 4 commits into from
Sep 11, 2023

Conversation

zhou9584
Copy link
Contributor

@zhou9584 zhou9584 commented Sep 8, 2023

Description

image

Linked GitHub issue ID:

Pull Request Checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Code compiles correctly with all tests are passed.
  • I've read the contributing guide and followed the recommended practices.
  • Wikis or README have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

If this introduces a breaking change for Hydra Lab users, please describe the impact and migration path.

  • Yes
  • No

How you tested it

Please make sure the change is tested, you can test it by adding UTs, do local test and share the screenshots, etc.
upload files with 4 threads and file size > 400MB in each thread
image

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Technical design
  • Build related changes
  • Refactoring (no functional changes, no api changes)
  • Code style update (formatting, renaming) or Documentation content changes
  • Other (please describe):

Feature UI screenshots or Technical design diagrams

If this is a relatively large or complex change, kick it off by drawing the tech design with PlantUML and explaining why you chose the solution you did and what alternatives you considered, etc...

hydraxman
hydraxman previously approved these changes Sep 8, 2023
@zhou9584 zhou9584 enabled auto-merge (squash) September 8, 2023 09:27
AC-Phoenix
AC-Phoenix previously approved these changes Sep 8, 2023
Co-authored-by: Nathan Bu <370788475@qq.com>
@zhou9584 zhou9584 dismissed stale reviews from AC-Phoenix and hydraxman via 2b4ad7d September 11, 2023 02:19
@zhou9584 zhou9584 merged commit 04ec4ea into main Sep 11, 2023
5 checks passed
@zhou9584 zhou9584 deleted the zhoule/Nginxbugfix branch September 11, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants