factor out .size() checks in GetDataType() (#4541)

* factor out .size() checks in GetDataType() * Update src/io/parser.cpp Co-authored-by: Nikita Titov <nekit94-08@mail.ru> Co-authored-by: Nikita Titov <nekit94-08@mail.ru>
microsoft · Aug 22, 2021 · 4db10d8 · 4db10d8
1 parent 4e18c60
commit 4db10d8
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/src/io/parser.cpp b/src/io/parser.cpp
@@ -184,15 +184,16 @@ DataType GetDataType(const char* filename, bool header,
   int tab_cnt = 0;
   int colon_cnt = 0;
   GetStatistic(lines[0].c_str(), &comma_cnt, &tab_cnt, &colon_cnt);
-  if (lines.size() == 1) {
+  size_t num_lines = lines.size();
+  if (num_lines == 1) {
     if (colon_cnt > 0) {
       type = DataType::LIBSVM;
     } else if (tab_cnt > 0) {
       type = DataType::TSV;
     } else if (comma_cnt > 0) {
       type = DataType::CSV;
     }
-  } else if (lines.size() > 1) {
+  } else {
     int comma_cnt2 = 0;
     int tab_cnt2 = 0;
     int colon_cnt2 = 0;
@@ -206,7 +207,7 @@ DataType GetDataType(const char* filename, bool header,
     }
     if (type == DataType::TSV || type == DataType::CSV) {
       // valid the type
-      for (size_t i = 2; i < lines.size(); ++i) {
+      for (size_t i = 2; i < num_lines; ++i) {
         GetStatistic(lines[i].c_str(), &comma_cnt2, &tab_cnt2, &colon_cnt2);
         if (type == DataType::TSV && tab_cnt2 != tab_cnt) {
           type = DataType::INVALID;