fix overflow in WeightedPercentile

microsoft · Apr 16, 2019 · 8ffd8d8 · 8ffd8d8
1 parent 5b5b982
commit 8ffd8d8
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/src/objective/regression_objective.hpp b/src/objective/regression_objective.hpp
@@ -65,7 +65,7 @@ namespace LightGBM {
   CHECK(threshold < weighted_cdf[pos]);\
   T v1 = data_reader(sorted_idx[pos - 1]);\
   T v2 = data_reader(sorted_idx[pos]);\
-  if (weighted_cdf[pos + 1] - weighted_cdf[pos] > kEpsilon) {\
+  if (weighted_cdf[pos + 1] - weighted_cdf[pos] >= 1.0f) {\
     return static_cast<T>((threshold - weighted_cdf[pos]) / (weighted_cdf[pos + 1] - weighted_cdf[pos]) * (v2 - v1) + v1); \
   } else {\
     return static_cast<T>(v2);\