Skip to content

Commit

Permalink
support macOS 10.14 Mojave (#1732)
Browse files Browse the repository at this point in the history
  • Loading branch information
StrikerRUS authored and guolinke committed Oct 5, 2018
1 parent de65958 commit f66716c
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion .ci/test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,8 @@ if [[ $TASK == "sdist" ]]; then
elif [[ $TASK == "bdist" ]]; then
if [[ $OS_NAME == "macos" ]]; then
cd $BUILD_DIRECTORY/python-package && python setup.py bdist_wheel --plat-name=macosx --universal || exit -1
mv dist/lightgbm-$LGB_VER-py2.py3-none-macosx.whl dist/lightgbm-$LGB_VER-py2.py3-none-macosx_10_6_x86_64.macosx_10_7_x86_64.macosx_10_8_x86_64.macosx_10_9_x86_64.macosx_10_10_x86_64.macosx_10_11_x86_64.macosx_10_12_x86_64.macosx_10_13_x86_64.whl
cp dist/lightgbm-$LGB_VER-py2.py3-none-macosx.whl dist/lightgbm-$LGB_VER-py2.py3-none-macosx_10_6_x86_64.macosx_10_7_x86_64.macosx_10_8_x86_64.macosx_10_9_x86_64.macosx_10_10_x86_64.whl
mv dist/lightgbm-$LGB_VER-py2.py3-none-macosx.whl dist/lightgbm-$LGB_VER-py2.py3-none-macosx_10_11_x86_64.macosx_10_12_x86_64.macosx_10_13_x86_64.macosx_10_14_x86_64.whl

This comment has been minimized.

Copy link
@guolinke

guolinke Nov 6, 2018

Collaborator

@StrikerRUS it seems pypi cannot support two macos binarines...

This comment has been minimized.

Copy link
@guolinke

guolinke Nov 6, 2018

Collaborator

there is a filename length limitation. Therefore, 10.6 and 10.7 cannot be supported.

This comment has been minimized.

Copy link
@StrikerRUS

StrikerRUS Nov 6, 2018

Author Collaborator

@guolinke
OK... 😢
How did you know about filename length limitation? PyPI rejected uploading?

This comment has been minimized.

Copy link
@StrikerRUS

StrikerRUS Nov 13, 2018

Author Collaborator

@guolinke Can you please answer about max filelength? I need to know it for another one project.

This comment has been minimized.

Copy link
@guolinke

guolinke Nov 14, 2018

Collaborator

I manually set the filename in windows, so it is the limitation in windows

This comment has been minimized.

Copy link
@StrikerRUS

StrikerRUS Nov 14, 2018

Author Collaborator

Ah, it was Windows! Got it. Thanks!

if [[ $AZURE == "true" ]]; then
cp dist/lightgbm-$LGB_VER-py2.py3-none-macosx*.whl $BUILD_ARTIFACTSTAGINGDIRECTORY
fi
Expand Down

0 comments on commit f66716c

Please sign in to comment.