Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CODEOWNERS #2194

Closed
jameslamb opened this issue May 26, 2019 · 1 comment
Closed

Add CODEOWNERS #2194

jameslamb opened this issue May 26, 2019 · 1 comment
Assignees
@henry0312 @chivee @huanzhang12 @Laurae2 @wxchan @guolinke @StrikerRUS
Labels
question

Comments

@jameslamb
Copy link
Collaborator

I learned from @Paxanator and @mjermann over on fRanz that GitHub supports a notion of "default reviewers" similar to Bitbucket.

You just have to add a .github/CODEOWNERS, per instructions here. You can even put owners on particular file extensions or sub-directories, which I think aligns well with the way we've been handling it.

This might save us a few clicks and put into code what we've been managing by convention.

Thoughts?
@guolinke
Copy link
Collaborator

very cool! let us add it.

jameslamb added a commit to jameslamb/LightGBM that referenced this issue May 27, 2019
@jameslamb
added CODEOWNERS (fixes microsoft#2194)
ceacc09
@jameslamb jameslamb mentioned this issue May 27, 2019
Merged
jameslamb added a commit to jameslamb/LightGBM that referenced this issue Jun 2, 2019
@jameslamb
added CODEOWNERS (fixes microsoft#2194)
dd39590
jameslamb added a commit to jameslamb/LightGBM that referenced this issue Jun 17, 2019
@jameslamb
added CODEOWNERS (fixes microsoft#2194)
0931189
jameslamb added a commit to jameslamb/LightGBM that referenced this issue Jul 17, 2019
@jameslamb
added CODEOWNERS (fixes microsoft#2194)
92b2252
@lock lock bot locked as resolved and limited conversation to collaborators Mar 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@henry0312 henry0312

@chivee chivee

@huanzhang12 huanzhang12

@Laurae2 Laurae2

@wxchan wxchan

@guolinke guolinke

@StrikerRUS StrikerRUS

Labels
question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@henry0312 @chivee @jameslamb @huanzhang12 @Laurae2 @wxchan @guolinke @StrikerRUS