Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] pass params to _InnerPredictor in train and cv and verbose fix #1628

Merged
merged 6 commits into from
Sep 6, 2018

Conversation

StrikerRUS
Copy link
Collaborator

Fixed #1157.

@guolinke Is it critical that all params are passed? It seems that unknown (for _InnerPredictor) keys in params are just silently ignored and it's OK.

@guolinke
Copy link
Collaborator

I think it is okay.

@StrikerRUS StrikerRUS changed the title [WIP][python] pass params to _InnerPredictor in train and cv [WIP][python] pass params to _InnerPredictor in train and cv and verbose fix Aug 30, 2018
@StrikerRUS
Copy link
Collaborator Author

StrikerRUS commented Aug 30, 2018

Updated verbosity param description according to the following code:
https://github.com/Microsoft/LightGBM/blob/7b6f80f350f41d522535d5f62ef9ad7a0cbb0f85/src/io/config.cpp#L182-L190

Treat silent argument as Fatal log level (verbose=-1) to prevent showing warnings with verbose=-1 in params and silent=True passed at the same time like in this use case. Also, do not overwrite verbose param (if already specified by user) by silent argument (treat silent the same way as in sklearn wrapper).

Create Dataset in refit method silently.

@StrikerRUS StrikerRUS changed the title [WIP][python] pass params to _InnerPredictor in train and cv and verbose fix [python] pass params to _InnerPredictor in train and cv and verbose fix Sep 6, 2018
@StrikerRUS StrikerRUS merged commit bd3889f into master Sep 6, 2018
@StrikerRUS StrikerRUS deleted the verbose branch September 6, 2018 12:04
@lock lock bot locked as resolved and limited conversation to collaborators Mar 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suppress LightGBM Warning
2 participants