[R-package] Fix build_r.R failing in Windows #1694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StrikerRUS
reviewed
Sep 23, 2018
build_r.R
Outdated
| @@ -1,4 +1,4 @@ | |||
| # for macOS users who have decided to use gcc | |||
| # Fr macOS users who have decided to use gcc | |||
StrikerRUS
reviewed
Sep 23, 2018
build_r.R
Outdated
| ) | ||
| result <- file.copy(from = "src/", | ||
| to = file.path("lightgbm_r", "src/") | ||
| , recursive = TRUE, |
jameslamb
approved these changes
Sep 23, 2018
| ) | ||
| result <- file.copy(from = "CMakeLists.txt", | ||
| to = file.path("lightgbm_r", "inst", "bin/"), | ||
| overwrite = TRUE) |
There was a problem hiding this comment.
is this what was causing the problem? (looks like you removed the recursive = TRUE)
A lot of these are formatting changes, so trying to find whichever thing was causing the issue
There was a problem hiding this comment.
I had two errors:
- on
devtools::document(pkg = "lightgbm_r/")(because of the trailing slash) - on the file with recursive (it causes a warning, which causes an error when R is setup to throw an error on warnings)
|
@jameslamb Do you have the rights to delete the branch fix-#1693 ? It seems I cannot delete it anymore (getting GitHub 404 error). |
|
@Laurae2 I've removed it:
|
|
Thanks @StrikerRUS ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1693