add indices in shuffle model. #1710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StrikerRUS
reviewed
Sep 28, 2018
python-package/lightgbm/basic.py
Outdated
| Index of the iteration that will start to shuffle. | ||
| end_iteration : int, optional (default=-1) | ||
| The last iteration that will be shuffled. | ||
| If <= 0, means the last iterations. |
There was a problem hiding this comment.
… last iteration.
Without s.
StrikerRUS
reviewed
Sep 28, 2018
src/boosting/gbdt.h
Outdated
| if (end_iter <= 0) { | ||
| end_iter = total_iter; | ||
| } | ||
| end_iter = std::min(total_iter, start_iter); |
There was a problem hiding this comment.
Maybe
end_iter = std::min(total_iter, end_iter);
?
There was a problem hiding this comment.
yeah, thanks so much.
StrikerRUS
approved these changes
Sep 28, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.