Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] documented version without OpenMP support #1811

Merged
merged 1 commit into from
Nov 5, 2018
Merged

[docs] documented version without OpenMP support #1811

merged 1 commit into from
Nov 5, 2018

Conversation

StrikerRUS
Copy link
Collaborator

@StrikerRUS StrikerRUS commented Oct 31, 2018 •
edited

Refer to #1780.

@StrikerRUS
Copy link
Collaborator Author

StrikerRUS commented Oct 31, 2018 •
edited

Should we relax CMake (and compilers) verions for OpenMP-less LightGBM or let it be as is?

@guolinke
Copy link
Collaborator

guolinke commented Nov 1, 2018

@StrikerRUS I think we can just let it be, as only mac os needs higher version to support openmp, and most macos users prefer newer versions.

@StrikerRUS
Copy link
Collaborator Author

@guolinke Agree.

@StrikerRUS
Copy link
Collaborator Author

Should OpenMP-less version be checked at CI side? Or, since it's not recommended version, we may not waste CI time?

@Laurae2
Copy link
Contributor

Laurae2 commented Nov 1, 2018

@StrikerRUS If nthread=1 then OpenMP is ignored when running a LightGBM model.

@StrikerRUS
Copy link
Collaborator Author

@Laurae2 Sorry, I was unclear. I mean compilation of the OpenMP-less version for the protection from cases like one was fixed in #1813.

@guolinke guolinke merged commit 5d46771 into master Nov 5, 2018
@StrikerRUS StrikerRUS deleted the openmp_docs branch November 5, 2018 09:57
@lock lock bot locked as resolved and limited conversation to collaborators Mar 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chivee chivee chivee approved these changes

@guolinke guolinke Awaiting requested review from guolinke guolinke is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@StrikerRUS @guolinke @Laurae2 @chivee