[docs] updated HDFS guide #1890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StrikerRUS
commented
Dec 3, 2018
docs/Installation-Guide.rst
Outdated
| @@ -569,6 +569,8 @@ On Linux HDFS version of LightGBM can be built using **CMake** and **gcc** or ** | |||
| git clone --recursive https://github.com/Microsoft/LightGBM ; cd LightGBM | |||
| mkdir build ; cd build | |||
| cmake -DUSE_HDFS=ON .. | |||
| # if you have installed HDFS to a customized location, you should specify paths to HDFS headers (hdfs.h) and library (libhdfs.so) like the following: | |||
| # cmake -DUSE_HDFS=ON -DHDFS_LIB_DIR=/usr/lib/hadoop-hdfs/lib -DHDFS_INCLUDE_DIR=/usr/lib/hadoop-hdfs/include/ .. | |||
There was a problem hiding this comment.
Maybe ask users to provide HDFS_LIB directly instead of HDFS_LIB_DIR?
https://github.com/Microsoft/LightGBM/blob/f55e37d02670374085d523357f0032ac544b6ed2/CMakeLists.txt#L109
StrikerRUS
commented
Dec 3, 2018
docs/Installation-Guide.rst
Outdated
| @@ -553,7 +553,7 @@ Refer to `GPU Docker folder <https://github.com/Microsoft/LightGBM/tree/master/d | |||
| Build HDFS Version | |||
| ~~~~~~~~~~~~~~~~~~ | |||
|
|
|||
| **Note**: Installation process of HDFS version is untested. | |||
| HDFS version of LightGBM was tested on CDH cluster. | |||
There was a problem hiding this comment.
@ebernhardson Can you please provide more details (i.e., version) to help users setup environment in which LightGBM will work fine?
|
@ebernhardson Please review. |
|
gently ping @ebernhardson |
|
Updated based on the comments from #2046.
I suppose that after merging this, #1555 can be closed. WDYT? |
guolinke
approved these changes
Apr 11, 2019
|
Sure |
|
Closed #1555. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer to #1555 (comment).