Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change variable name test_data > validation_data #2018

Merged
merged 1 commit into from Feb 18, 2019

Conversation

morenoh149
Copy link
Contributor

  • it is confusing to name validation data test_data especially as terms like train, validation, test splits are common in ML. Change variable name in python quick start.

@morenoh149 morenoh149 closed this Feb 16, 2019
@morenoh149 morenoh149 reopened this Feb 16, 2019
* it is confusing to name validation data `test_data` especially as terms like train, validation, test splits are common in ML. Change variable name in python quick start.
@guolinke
Copy link
Collaborator

guolinke commented Feb 18, 2019

please merge the latest master branch to ensure the test-passing.

updated:
I found this PR is related to doc, so I will merge it directly.

@guolinke guolinke merged commit a777aed into microsoft:master Feb 18, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Mar 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants