New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in GatherInfoForThresholdCategorical #2040

Merged

guolinke merged 1 commit into microsoft:master from rvb:fix-typo

Mar 9, 2019

Contributor

remcob-gr commented Mar 8, 2019

This typo leads to incorrect gain values, which could lead to a forced split being incorrectly rejected.


          Fix typo in GatherInfoForThresholdCategorical

StrikerRUS requested a review from guolinke

March 8, 2019 18:42

guolinke approved these changes

View reviewed changes

guolinke merged commit 9de526f into microsoft:master

lock bot locked as resolved and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.