Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

addressed cpplint error about C-style cast #2064

Merged
merged 3 commits into from Apr 1, 2019
Merged

addressed cpplint error about C-style cast #2064

merged 3 commits into from Apr 1, 2019

Conversation

StrikerRUS
Copy link
Collaborator

@StrikerRUS StrikerRUS commented Mar 22, 2019 •
edited

@guolinke
Copy link
Collaborator

thanks @StrikerRUS
there are not good solutions for these casts. I think we can live with them for now.

@StrikerRUS
Copy link
Collaborator Author

StrikerRUS commented Mar 25, 2019 •
edited

@guolinke Thank you, got it! I'll try to find the way to ignore them in cpplint.

@StrikerRUS StrikerRUS merged commit 2027f6b into master Apr 1, 2019
@StrikerRUS StrikerRUS deleted the cpplint_cast branch April 1, 2019 12:09
@lock lock bot locked as resolved and limited conversation to collaborators Mar 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@guolinke guolinke guolinke approved these changes

@chivee chivee Awaiting requested review from chivee

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@StrikerRUS @guolinke