Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] add flag of displaying train loss for lgb.cv() #2089

Merged
merged 7 commits into from Apr 16, 2019

Conversation

matsuken92
Copy link
Contributor

Adding flag on lgb.cv() for displaying train loss during training iteration.

@matsuken92 matsuken92 changed the title [python] add flag for displaying train loss [python] add flag for displaying train loss for lgb.cv() Apr 9, 2019
@matsuken92 matsuken92 changed the title [python] add flag for displaying train loss for lgb.cv() [python] add flag of displaying train loss for lgb.cv() Apr 9, 2019
@StrikerRUS
Copy link
Collaborator

Closed #1105.
Glad to see how very old issues are closing! 😃

.idea/LightGBM.iml Outdated Show resolved Hide resolved
@StrikerRUS
Copy link
Collaborator

I began to doubt in new parameter name. Seems that I was wrong when suggested to rename disp_* -> show_*. Both these words describe some appearance. There are even the following remark in show_stdv description:

Results are not affected by this parameter, and always contain std.

In contrast, new parameter affects performance because requires additional metric computation for train dataset.
I think we need a better word. What about calc(ulate), comp(ute), eval(uate)? I personally prefer eval.

BTW, loss should be replaced with metric for the clarity too.

python-package/lightgbm/engine.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@StrikerRUS StrikerRUS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matsuken92 Thanks a lot for this nice feature! I'm OK to merge after fixing two very minor nitpicks below.

python-package/lightgbm/engine.py Outdated Show resolved Hide resolved
python-package/lightgbm/engine.py Outdated Show resolved Hide resolved
@henry0312
Copy link
Contributor

henry0312 commented Apr 16, 2019

I'm sorry for rate response but I didn't have much time because of moving.
I'll check today.

@henry0312 henry0312 merged commit ca85b67 into microsoft:master Apr 16, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Mar 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants