[python] make possibility to create Booster from string official #2098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StrikerRUS
commented
Apr 12, 2019
| @@ -1578,7 +1578,7 @@ def dump_text(self, filename): | |||
| class Booster(object): | |||
| """Booster in LightGBM.""" | |||
|
|
|||
| def __init__(self, params=None, train_set=None, model_file=None, silent=False): | |||
| def __init__(self, params=None, train_set=None, model_file=None, model_str=None, silent=False): | |||
There was a problem hiding this comment.
Yeah, I know that for the backward compatibility new param should be the last one. But it's too illogical to split train_set=None, model_file=None, model_str=None params (especially model_file=None, model_str=None), in which at least one should be specified by a user.
guolinke
approved these changes
Apr 13, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #2097.