[SWIG] added typemap for string arrays in SWIG interface #2118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imatiach-msft
changed the title
imatiach-msft
force-pushed
the
ilmat/str-SWIG
branch
from
e84348f
to
aebbdbe
Compare
guolinke
approved these changes
Apr 29, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added typemap for string arrays in SWIG interface
This is needed for PR in mmlspark repository: microsoft/SynapseML#526
To resolve issue in mmlspark: microsoft/SynapseML#332
Edit:
also added voidp pointer casts needed for PR that adds LGBMRanker to MMLSpark: microsoft/SynapseML#554
To resolve issues in mmlspark: microsoft/SynapseML#543
and also: microsoft/SynapseML#446