Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] fixed minor typos #2119

Merged
merged 2 commits into from Apr 28, 2019
Merged

[docs] fixed minor typos #2119

merged 2 commits into from Apr 28, 2019

Conversation

StrikerRUS
Copy link
Collaborator

@StrikerRUS StrikerRUS commented Apr 19, 2019

Sorry, overlooked yesterday in #2116 that param name in CLI version is slight different.

@jameslamb
Copy link
Collaborator

@StrikerRUS Is it critical that @guolinke review this? Seems pretty non-controversial. I can give a review and merge, if you'd like

@StrikerRUS
Copy link
Collaborator Author

Oh, @jameslamb, of course it's not critical at all. Thanks a lot!

@jameslamb jameslamb self-requested a review April 28, 2019 20:34
Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jameslamb jameslamb merged commit 24ad35f into master Apr 28, 2019
@StrikerRUS StrikerRUS deleted the typos branch April 28, 2019 20:44
@lock lock bot locked as resolved and limited conversation to collaborators Mar 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants