Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R-package] Fix best_iter and best_score #2159

Merged
merged 7 commits into from
May 27, 2019
Merged

[R-package] Fix best_iter and best_score #2159

merged 7 commits into from
May 27, 2019

Commits on May 8, 2019

  1. Callback for NA handling

    @Laurae2
    Laurae2 committed May 8, 2019
    Configuration menu
    Copy the full SHA
    d34516d View commit details
    Browse the repository at this point in the history

  2. lgb.Booster default score => NA

    @Laurae2
    Laurae2 committed May 8, 2019
    Configuration menu
    Copy the full SHA
    dec2d36 View commit details
    Browse the repository at this point in the history

  3. lgb.cv default best score => NA

    @Laurae2
    Laurae2 committed May 8, 2019
    Configuration menu
    Copy the full SHA
    1a33eeb View commit details
    Browse the repository at this point in the history

  4. Fix back callback

    @Laurae2
    Laurae2 committed May 8, 2019
    Configuration menu
    Copy the full SHA
    e6783c5 View commit details
    Browse the repository at this point in the history

  5. lgb.train with booster check at the end 

    manual tests done: 
* With early stopping + with validation set
* With early stopping + without validation set
* Without early stopping + with validation set
* Without early stopping + without validation set

And with multiple metrics / validation sets.
    @Laurae2
    Laurae2 committed May 8, 2019
    Configuration menu
    Copy the full SHA
    e0236c9 View commit details
    Browse the repository at this point in the history

  6. lgb.cv with booster check at the end 

    manual tests done: 
* With early stopping + with validation set
* With early stopping + without validation set
* Without early stopping + with validation set
* Without early stopping + without validation set

And with multiple metrics / validation sets.
    @Laurae2
    Laurae2 committed May 8, 2019
    Configuration menu
    Copy the full SHA
    949861e View commit details
    Browse the repository at this point in the history

Commits on May 27, 2019

  1. Merge remote-tracking branch 'origin/master' into fix-#2029

    @StrikerRUS
    StrikerRUS committed May 27, 2019
    Configuration menu
    Copy the full SHA
    5e558b3 View commit details
    Browse the repository at this point in the history