Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] added swig compilation on macOS and Windows with artifacts #2170

Merged
merged 14 commits into from May 14, 2019
Merged

Conversation

StrikerRUS
Copy link
Collaborator

@StrikerRUS StrikerRUS commented May 13, 2019

  • Compile SWIG wrapper under the sdist job to speed up overall CI run (sdist was chosen because we run less tests in it);
  • add SWIG compilation on macOS and Windows;
  • enhance condition field to fix warnings about empty artifacts folder:
    image

Azul Zulu OpenJDK is used to compile SWIG wrapper because it's:

  • pre-installed on Azure Hosted Agents,
  • free to use,
  • updated regularly.

Blog post: https://azure.microsoft.com/en-us/blog/microsoft-and-azul-systems-bring-free-java-lts-support-to-azure/

JAVA_HOME_8_X64 variable was taken from Azure image generation script:

@StrikerRUS StrikerRUS changed the title [ci] added job for swig compilation on macOS and Windows with artifacts [ci] added swig compilation on macOS and Windows with artifacts May 13, 2019
@StrikerRUS StrikerRUS closed this May 13, 2019
@StrikerRUS StrikerRUS reopened this May 13, 2019
@StrikerRUS
Copy link
Collaborator Author

ping @imatiach-msft

@StrikerRUS StrikerRUS requested a review from guolinke May 13, 2019 12:39
Copy link
Contributor

@imatiach-msft imatiach-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@StrikerRUS
Copy link
Collaborator Author

@imatiach-msft I haven't included merging script into pipeline because there is no possibly to remove already published artifacts from previous jobs. I mean, if I downloaded JARs from Linux, Windows and macOS and then merged them into one final JAR and publish it, all OS-specific JARs are still in PackageAssets artifact. This enlarges overall artifact size significantly.

@StrikerRUS StrikerRUS merged commit 2a36917 into master May 14, 2019
@StrikerRUS StrikerRUS deleted the swig branch May 14, 2019 11:51
@lock lock bot locked as resolved and limited conversation to collaborators Mar 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants