Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] updated js file attaching mechanism #2287

Merged
merged 1 commit into from Jul 27, 2019
Merged

[docs] updated js file attaching mechanism #2287

merged 1 commit into from Jul 27, 2019

Conversation

StrikerRUS
Copy link
Collaborator

Changed in version 1.8: Renamed from app.add_javascript(). And it allows keyword arguments as attributes of script tag.
https://www.sphinx-doc.org/en/master/extdev/appapi.html#sphinx.application.Sphinx.add_js_file

@jameslamb
Copy link
Collaborator

wow @StrikerRUS you know Javascript too? 😂

@StrikerRUS
Copy link
Collaborator Author

@jameslamb Huh, a little bit, just basics 😃

@StrikerRUS StrikerRUS merged commit 5dc1507 into master Jul 27, 2019
@StrikerRUS StrikerRUS deleted the sphinx branch July 27, 2019 11:34
@lock lock bot locked as resolved and limited conversation to collaborators Mar 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jameslamb jameslamb jameslamb approved these changes

@guolinke guolinke guolinke approved these changes

@Laurae2 Laurae2 Awaiting requested review from Laurae2

@henry0312 henry0312 Awaiting requested review from henry0312

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@StrikerRUS @jameslamb @guolinke