Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow passing empty value in parameters #2289

Merged
merged 1 commit into from Jul 28, 2019
Merged

allow passing empty value in parameters #2289

merged 1 commit into from Jul 28, 2019

Conversation

guolinke
Copy link
Collaborator

to fix #2285

Copy link
Collaborator

@StrikerRUS StrikerRUS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@guolinke Just checked - original issue is fixed! But there is only one edge case where warning is not shown, but it should be. Don't know is it worth to "fix" it.

Unknown parameter with empty value:

import lightgbm as lgb
from sklearn.datasets import load_boston

lgb_train = lgb.Dataset(*load_boston(True))
lgb.train({'sdfsdfsfsfsd': ''}, lgb_train, num_boost_round=10)

src/io/config.cpp Outdated Show resolved Hide resolved
src/io/config.cpp Outdated Show resolved Hide resolved
@guolinke guolinke reopened this Jul 27, 2019
@guolinke guolinke closed this Jul 27, 2019
@guolinke guolinke reopened this Jul 27, 2019
@guolinke guolinke merged commit 274f340 into master Jul 28, 2019
@StrikerRUS StrikerRUS deleted the guolinke-patch-1 branch July 28, 2019 11:14
@lock lock bot locked as resolved and limited conversation to collaborators Mar 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unknown parameter warning when set to empty string
2 participants