[docs] remove aliases from options in params and remove separators in FAQ #2296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
StrikerRUS
commented
Jul 31, 2019
StrikerRUS
commented
- Remove aliases from boosting options in parameters for the consistency with other parameters.
- Remove question separators from FAQ as they consume a lot of space on the page and for brief solutions it may seem that there is no solution at all (your attention is focused on a big dash instead of an answer).
jameslamb
approved these changes
Aug 6, 2019
| @@ -182,7 +160,7 @@ An alternative, if multithreading is really necessary inside the forked sessions | |||
| Intel toolchain. Intel compilers are unaffected by this bug. | |||
|
|
|||
| For C/C++ users, any OpenMP feature cannot be used before the fork happens. If an OpenMP feature is used before the | |||
| fork happens (ex: using OpenMP for forking), OpenMP will hang inside the forked sessions. Use new processes instead | |||
| fork happens (example: using OpenMP for forking), OpenMP will hang inside the forked sessions. Use new processes instead | |||
There was a problem hiding this comment.
this is a good change, I think shortened words like this can be a bit unfriendly to users for whom English is not their first language
guolinke
approved these changes
Aug 6, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.