Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix nan in tree model #2303

Merged
merged 2 commits into from Aug 14, 2019
Merged

fix nan in tree model #2303

merged 2 commits into from Aug 14, 2019

Conversation

guolinke
Copy link
Collaborator

@guolinke guolinke commented Aug 1, 2019 •
edited

to fix #2266

also refer to #2277
I think a better solution is let json support inf and nan, not to chang model content.

@guolinke guolinke changed the title fix nan in tree model [WIP] fix nan in tree model Aug 1, 2019
@guolinke guolinke changed the title [WIP] fix nan in tree model fix nan in tree model Aug 1, 2019
@guolinke
Copy link
Collaborator Author

guolinke commented Aug 1, 2019

The new solution, only converting inf/nan when dump json.

@guolinke guolinke merged commit 9558417 into master Aug 14, 2019
@StrikerRUS StrikerRUS deleted the guolinke-patch-1 branch August 16, 2019 11:06
@StrikerRUS StrikerRUS mentioned this pull request Sep 11, 2019
Closed
@lock lock bot locked as resolved and limited conversation to collaborators Mar 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JSONDecodeError: Expecting value when using lgb.plot_tree
1 participant
@guolinke