Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] fixed params description #2306

Merged
merged 2 commits into from Aug 4, 2019
Merged

[docs] fixed params description #2306

merged 2 commits into from Aug 4, 2019

Conversation

StrikerRUS
Copy link
Collaborator

Refer to #2163 (comment).

@guolinke To be honest, I'm not sure that pos_bagging_fraction and neg_bagging_fraction are used in MultiClassOVA. It seems to me that according to the code below, num_pos_data = 0 and balance_bagging_cond = false because MultiClassOVA objective doesn't override NumPositiveData().

data_size_t num_pos_data = 0;
if (objective_function_ != nullptr) {
num_pos_data = objective_function_->NumPositiveData();
}
bool balance_bagging_cond = (config->pos_bagging_fraction < 1.0 || config->neg_bagging_fraction < 1.0) && (num_pos_data > 0);

Please tell how it is actually working.

@StrikerRUS
Copy link
Collaborator Author

@guolinke Was I right about *_bagging_fraction params?

@guolinke
Copy link
Collaborator

guolinke commented Aug 4, 2019

I think they are only used for binary classification.

@StrikerRUS StrikerRUS merged commit 28dc333 into master Aug 4, 2019
@StrikerRUS StrikerRUS deleted the docs_params branch August 4, 2019 21:24
@lock lock bot locked as resolved and limited conversation to collaborators Mar 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants