Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] add if-else job to Travis #2389

Merged
merged 1 commit into from Sep 9, 2019
Merged

[ci] add if-else job to Travis #2389

merged 1 commit into from Sep 9, 2019

Conversation

StrikerRUS
Copy link
Collaborator

To be honest, I have no idea when it was lost from there.

Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@StrikerRUS what does if-else task do?

Anyway, looks good to me! The only thing failing on Travis is the check-docs task, link checker is getting a 502 from https://www.mcs.anl.gov/~thakur/papers/ijhpca-coll.pdf

@StrikerRUS
Copy link
Collaborator Author

StrikerRUS commented Sep 7, 2019

@jameslamb

Anyway, looks good to me! The only thing failing on Travis is the check-docs task, link checker is getting a 502 from https://www.mcs.anl.gov/~thakur/papers/ijhpca-coll.pdf

Thanks for your review! Yeah, this site is down again. 😠 I think till Monday, based on the previous experience.

what does if-else task do?

It converts a model, refer to
https://lightgbm.readthedocs.io/en/latest/Parameters.html#convert_model

LightGBM/.ci/test.sh

Lines 60 to 67 in b6d4ad8

if [[ $TASK == "if-else" ]]; then
conda install -q -y -n $CONDA_ENV numpy
mkdir $BUILD_DIRECTORY/build && cd $BUILD_DIRECTORY/build && cmake "${CMAKE_OPTS[@]}" .. && make lightgbm -j4 || exit -1
cd $BUILD_DIRECTORY/tests/cpp_test && ../../lightgbm config=train.conf convert_model_language=cpp convert_model=../../src/boosting/gbdt_prediction.cpp && ../../lightgbm config=predict.conf output_result=origin.pred || exit -1
cd $BUILD_DIRECTORY/build && make lightgbm -j4 || exit -1
cd $BUILD_DIRECTORY/tests/cpp_test && ../../lightgbm config=predict.conf output_result=ifelse.pred && python test.py || exit -1
exit 0
fi

@StrikerRUS
Copy link
Collaborator Author

Close-reopen for CI.

@StrikerRUS StrikerRUS closed this Sep 9, 2019
@StrikerRUS StrikerRUS reopened this Sep 9, 2019
@StrikerRUS StrikerRUS merged commit b310fb4 into master Sep 9, 2019
@StrikerRUS StrikerRUS deleted the if_else branch September 9, 2019 17:08
@lock lock bot locked as resolved and limited conversation to collaborators Mar 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants