Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] refer to RTD site directly #2415

Merged
merged 1 commit into from Sep 24, 2019
Merged

[docs] refer to RTD site directly #2415

merged 1 commit into from Sep 24, 2019

Conversation

StrikerRUS
Copy link
Collaborator

Pros:

  • -1 click for users to reach R-API reference;
  • -1 broken link in GitHub repo (./R/reference).

Cons:

  • language and version settings for RTD (en/latest, if we will make them in the future) will be reset in case users want to get back to index page.
    image

jameslamb
jameslamb approved these changes Sep 17, 2019
View reviewed changes
Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@jameslamb jameslamb merged commit 2e9f255 into master Sep 24, 2019
@StrikerRUS StrikerRUS deleted the docs branch September 25, 2019 11:38
@lock lock bot locked as resolved and limited conversation to collaborators Mar 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jameslamb jameslamb jameslamb approved these changes

@Laurae2 Laurae2 Awaiting requested review from Laurae2

@guolinke guolinke Awaiting requested review from guolinke guolinke is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@StrikerRUS @jameslamb