Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the objective init issues in distributed mode #2420

Merged
merged 2 commits into from Sep 19, 2019

Conversation

guolinke
Copy link
Collaborator

to fix #2419

sizeof(local), sizeof(local),
reinterpret_cast<char*>(&global),
[](const char* src, char* dst, int type_size, comm_size_t len) {
comm_size_t used_size = 0;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it result of the recently added .editorconfig file?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I edit the code by the vs2019, so I am not sure.

Copy link
Contributor

@imatiach-msft imatiach-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great fix!

@guolinke guolinke merged commit a119639 into master Sep 19, 2019
@guolinke guolinke deleted the distributed-init-score branch September 19, 2019 07:54
@lock lock bot locked as resolved and limited conversation to collaborators Mar 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LightGBM distributed training can get stuck in some edge-case scenarios with labels missing on some partitions
3 participants