Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R-package] fixed minor issues with tests and documentation #2581

Merged
merged 1 commit into from Nov 25, 2019

Conversation

jameslamb
Copy link
Collaborator

This PR addresses a few issues found during #2530 . Splitting them out into a separate PR because I think they can go through a much quicker review, and we need to fix them regardless of what is decided in #2530 .

  1. extra comma in lgb.cv.R. fixes:
lgb.cv : <anonymous>: missing arguments not allowed in calls to ‘list’
  1. missing quote in documentation in lgb.prepare_rules2.R. fixes:
Error: LaTeX error. Mismatched quote or braces
  1. two uses of expect_true() where test_that() should have been used in test_parameters.R
  2. fix to avoid warning from R CMD check
multiple.tree.interprete: no visible binding for global variable
  ‘abs_contribution’
Undefined global functions or variables:
  abs_contribution

None of these changes impact the roxygen documentation, so there are no man/ file changes in the diff.

Copy link
Collaborator

@StrikerRUS StrikerRUS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jameslamb jameslamb merged commit 102893a into microsoft:master Nov 25, 2019
@jameslamb jameslamb deleted the bugfix/r_package branch January 27, 2020 00:14
@lock lock bot locked as resolved and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants