Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CODEOWNERS rule about CMakeLists.txt #3079

Merged
merged 1 commit into from May 13, 2020
Merged

Conversation

jameslamb
Copy link
Collaborator

Noticed in #3076 that not all C++ maintainers were added as reviewers for a change to CMakeLists.txt. I think this change will fix that 😀

Copy link
Collaborator

@StrikerRUS StrikerRUS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@jameslamb
Copy link
Collaborator Author

Something very strange is going on with our CI today.

Azure

I see two copies of the Mac and Azure r_package builds, and they are just sitting waiting (https://dev.azure.com/lightgbm-ci/lightgbm-ci/_build/results?buildId=6122&view=results)

image

I wonder if it is Azure capacity issues again? I see a few different jobs stuck in "Queued" across several of our Azure builds right now.

According to Azure status page there are no ongoing incidents, and the most recent one was two days ago

Travis

I'm also confused by the ❌ on Travis for this PR

image

If you click Details you'll see that all Travis builds are passing (https://travis-ci.org/github/microsoft/LightGBM/builds/686636061).

According to the Travis status page there are no ongoing incidents, and the most recent one was two weeks ago

@StrikerRUS
Copy link
Collaborator

StrikerRUS commented May 13, 2020

@jameslamb

I'm also confused by the ❌ on Travis for this PR

Please push empty commit after one hour. There are no any other workarounds for push (not PR) CI webhook issues.

No need! I managed to reanimate Travis by re-running random job.

@StrikerRUS StrikerRUS merged commit e5b7c7b into master May 13, 2020
@StrikerRUS StrikerRUS deleted the jameslamb-patch-1 branch May 13, 2020 22:52
ChipKerchner pushed a commit to ChipKerchner/LightGBM that referenced this pull request Jun 10, 2020
ChipKerchner pushed a commit to ChipKerchner/LightGBM that referenced this pull request Jun 11, 2020
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants