Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R-package] fix typo in R installation instructions #3350

Merged
merged 2 commits into from Sep 4, 2020

Conversation

daviddalpiaz
Copy link
Contributor

Fixes typo to allow for copy-paste installation of R package.

@jameslamb
Copy link
Collaborator

@daviddalpiaz thanks for using LightGBM and for contributing here! Sorry, but this issue you've found is my mistake. Our goal was to make all of the artifact names kebob case (lightgbm-{version}-r-cran.tar.gz), but since we haven't done #3283 I'm making them manually, and made a mistake.

I just uploaded the 3.0.0rc1 release with the kebob-case name, so the instructions will be correct. I left the snake_case one up there to not break anyone's code.

Now that we've released 3.0.0, could you change this PR to reference version 3.0.0?

https://github.com/microsoft/LightGBM/releases/download/v3.0.0/lightgbm-3.0.0-r-cran.tar.gz

@daviddalpiaz
Copy link
Contributor Author

Huh. I could have sworn in looked for the R release of 3.0.0, but guess I missed it! Thanks for all the hard work. Hoping for CRAN soon so I can encourage my students to use LightGBM!

@jameslamb jameslamb added the doc label Sep 4, 2020
@jameslamb jameslamb changed the title fix typo in R installation instructions [R-package] fix typo in R installation instructions Sep 4, 2020
@jameslamb
Copy link
Collaborator

Huh. I could have sworn in looked for the R release of 3.0.0, but guess I missed it! Thanks for all the hard work. Hoping for CRAN soon so I can encourage my students to use LightGBM!

I just added it last night 😀

we are so so so close to CRAN, I can't wait til we don't have to make people deal with this. Thanks for being patient with us, for using LightGBM, and for coming here to contribute!

Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! I'll merge this as soon as it builds

@daviddalpiaz
Copy link
Contributor Author

Excellent! Thanks again!

@jameslamb jameslamb merged commit aa18f84 into microsoft:master Sep 4, 2020
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants