[R package] update lgb.Dataset.R to use keyword arguments #3607
Conversation
There was a problem hiding this comment.
Thanks again for taking time to contribute to LightGBM!
I left some small suggestions. Please also fix the linting errors listed in https://travis-ci.org/github/microsoft/LightGBM/jobs/746519935. You can reproduce these errors locally by running Rscript .ci/lint_r_code.R $(pwd).
@zenggyu one other question...are you interested in completely finishing #3390 ? I originally set it up file-by-file like that for Hacktoberfest, but now that Hacktoberfest is over I'd like to finish it. If you have the time and interest, I'd be grateful if you'd handle the rest of the files there in one or two additional pull requests after this one (doesn't have to be one-fiile-per-PR).
| @@ -277,7 +277,7 @@ Dataset <- R6::R6Class( | |||
|
|
|||
| # Setup initial scores | |||
| init_score <- private$predictor$predict( | |||
| private$raw_data | |||
| data = private$raw_data | |||
There was a problem hiding this comment.
this is correct! Just pointing out since you weren't sure, this is an instance of Predictor and comes from
LightGBM/R-package/R/lgb.Predictor.R
Line 77 in efa9ecf
Co-authored-by: James Lamb <jaylamb20@gmail.com>
|
@zenggyu it looks like many of your commits were done under a profile that is not linked to your GitHub Account. I can see this because your profile picture doesn't show up next to them.
I recommend that when you work on open source stuff, you set your gitconfig with an email address tied to your GitHub Account. This will make sure your user has credit in projects' "Contributors" list, and that the GitHub activity overview is accurate. I described how to fix this in uptake/pkgnet#284 (review). If you try that and get stuck, let me know and I'd be happy to help. |
|
Thanks for telling me! I changed my email setting in git config a few days ago and I would prefer to use this new address. Let me try changing the primary email address of my github account (this should not require any changes in the git config right?). |
|
OK, I think I have fixed it. |
yep, looks good! |
Co-authored-by: James Lamb <jaylamb20@gmail.com>
|
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
Addresses part of #3390. Two notes:
lgb.is.Dataset(x)). I don't know if it is necessary to modify these function calls to use keyword arguments; if it is, please let me know and I'll make a new commit to modify all these function calls.private$predictor$predict()isdata?Thank you @jameslamb for providing this learning opportunity! I am already learning something new about git and github!